itsdave/msp
2
0
Fork 0
mirror of https://github.com/itsdave-de/msp.git synced 2025-10-30 08:57:09 -03:00
Code Issues Actions Packages Projects Releases Wiki Activity

#15 | Apply tell don't ask and move colors dict to method where is needed

Browse Source
This commit is contained in:
Jordi Albert 2022-07-20 08:22:58 +02:00
parent b7a89d41eb
commit 3bcd65c052
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
msp/msp/doctype/it_object/it_object.py
View File

@ -9,7 +9,7 @@ from frappe.model.document import Document
class ITObject(Document): class ITObject(Document):
def get_host_status_from_hosts_data(self, hosts_data, status_colors): def get_host_status_from_hosts_data(self, hosts_data, msp_settings_doc):
host_data_response = {} host_data_response = {}
@ -39,7 +39,11 @@ class ITObject(Document):
} }
} }
}, },
'statusColors': status_colors 'statusColors': {
'upStateColor': msp_settings_doc.oitc_status_up_color,
'downStateColor': msp_settings_doc.oitc_status_down_color,
'unreachableStateColor': msp_settings_doc.oitc_status_unreachable_color
}
} }
return host_data_response return host_data_response
@ -62,12 +66,7 @@ class ITObject(Document):
hosts_data = requests.get(url=endpoint, headers=headers, verify=False) hosts_data = requests.get(url=endpoint, headers=headers, verify=False)
status_colors = { return self.get_host_status_from_hosts_data(hosts_data.json(), msp_settings_doc)
'upStateColor': msp_settings_doc.oitc_status_up_color,
'downStateColor': msp_settings_doc.oitc_status_down_color,
'unreachableStateColor': msp_settings_doc.oitc_status_unreachable_color
}
return self.get_host_status_from_hosts_data(hosts_data.json(), status_colors)
except Exception as exception: except Exception as exception:
exception_message = f'Data could not be fetched from {msp_settings_doc.oitc_url}. Error -> {str(exception)}' exception_message = f'Data could not be fetched from {msp_settings_doc.oitc_url}. Error -> {str(exception)}'