build: update npm install command to use --legacy-peer-deps
This change modifies the build scripts to use --legacy-peer-deps flag when installing npm dependencies to resolve potential peer dependency conflicts during the build process. The change is applied to both bash (build.sh) and batch (build.bat) build scripts.
This commit is contained in:
Luiz Costa committed
1 parent
20129a1ac7
commit
ac4f232e5e
787 files changed
+82341
-121690
No files matched your search
+316
-361
@@ -16,12 +16,9 @@ const astUtils = require("./utils/ast-utils");
|
||||
// Helpers
|
||||
//------------------------------------------------------------------------------
|
||||
|
||||
const PATTERN_TYPE =
|
||||
/^(?:.+?Pattern|RestElement|SpreadProperty|ExperimentalRestProperty|Property)$/u;
|
||||
const DECLARATION_HOST_TYPE =
|
||||
/^(?:Program|BlockStatement|StaticBlock|SwitchCase)$/u;
|
||||
const DESTRUCTURING_HOST_TYPE =
|
||||
/^(?:VariableDeclarator|AssignmentExpression)$/u;
|
||||
const PATTERN_TYPE = /^(?:.+?Pattern|RestElement|SpreadProperty|ExperimentalRestProperty|Property)$/u;
|
||||
const DECLARATION_HOST_TYPE = /^(?:Program|BlockStatement|StaticBlock|SwitchCase)$/u;
|
||||
const DESTRUCTURING_HOST_TYPE = /^(?:VariableDeclarator|AssignmentExpression)$/u;
|
||||
|
||||
/**
|
||||
* Checks whether a given node is located at `ForStatement.init` or not.
|
||||
@@ -29,7 +26,7 @@ const DESTRUCTURING_HOST_TYPE =
|
||||
* @returns {boolean} `true` if the node is located at `ForStatement.init`.
|
||||
*/
|
||||
function isInitOfForStatement(node) {
|
||||
return node.parent.type === "ForStatement" && node.parent.init === node;
|
||||
return node.parent.type === "ForStatement" && node.parent.init === node;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -38,18 +35,20 @@ function isInitOfForStatement(node) {
|
||||
* @returns {boolean} `true` if the node can become a VariableDeclaration.
|
||||
*/
|
||||
function canBecomeVariableDeclaration(identifier) {
|
||||
let node = identifier.parent;
|
||||
let node = identifier.parent;
|
||||
|
||||
while (PATTERN_TYPE.test(node.type)) {
|
||||
node = node.parent;
|
||||
}
|
||||
while (PATTERN_TYPE.test(node.type)) {
|
||||
node = node.parent;
|
||||
}
|
||||
|
||||
return (
|
||||
node.type === "VariableDeclarator" ||
|
||||
(node.type === "AssignmentExpression" &&
|
||||
node.parent.type === "ExpressionStatement" &&
|
||||
DECLARATION_HOST_TYPE.test(node.parent.parent.type))
|
||||
);
|
||||
return (
|
||||
node.type === "VariableDeclarator" ||
|
||||
(
|
||||
node.type === "AssignmentExpression" &&
|
||||
node.parent.type === "ExpressionStatement" &&
|
||||
DECLARATION_HOST_TYPE.test(node.parent.parent.type)
|
||||
)
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -60,21 +59,18 @@ function canBecomeVariableDeclaration(identifier) {
|
||||
* @returns {boolean} Indicates if the variable is from outer scope or function parameters.
|
||||
*/
|
||||
function isOuterVariableInDestructing(name, initScope) {
|
||||
if (
|
||||
initScope.through.some(
|
||||
ref => ref.resolved && ref.resolved.name === name,
|
||||
)
|
||||
) {
|
||||
return true;
|
||||
}
|
||||
|
||||
const variable = astUtils.getVariableByName(initScope, name);
|
||||
if (initScope.through.some(ref => ref.resolved && ref.resolved.name === name)) {
|
||||
return true;
|
||||
}
|
||||
|
||||
if (variable !== null) {
|
||||
return variable.defs.some(def => def.type === "Parameter");
|
||||
}
|
||||
const variable = astUtils.getVariableByName(initScope, name);
|
||||
|
||||
return false;
|
||||
if (variable !== null) {
|
||||
return variable.defs.some(def => def.type === "Parameter");
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -87,19 +83,19 @@ function isOuterVariableInDestructing(name, initScope) {
|
||||
* null.
|
||||
*/
|
||||
function getDestructuringHost(reference) {
|
||||
if (!reference.isWrite()) {
|
||||
return null;
|
||||
}
|
||||
let node = reference.identifier.parent;
|
||||
if (!reference.isWrite()) {
|
||||
return null;
|
||||
}
|
||||
let node = reference.identifier.parent;
|
||||
|
||||
while (PATTERN_TYPE.test(node.type)) {
|
||||
node = node.parent;
|
||||
}
|
||||
while (PATTERN_TYPE.test(node.type)) {
|
||||
node = node.parent;
|
||||
}
|
||||
|
||||
if (!DESTRUCTURING_HOST_TYPE.test(node.type)) {
|
||||
return null;
|
||||
}
|
||||
return node;
|
||||
if (!DESTRUCTURING_HOST_TYPE.test(node.type)) {
|
||||
return null;
|
||||
}
|
||||
return node;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -112,43 +108,42 @@ function getDestructuringHost(reference) {
|
||||
* a MemberExpression, false if not.
|
||||
*/
|
||||
function hasMemberExpressionAssignment(node) {
|
||||
switch (node.type) {
|
||||
case "ObjectPattern":
|
||||
return node.properties.some(prop => {
|
||||
if (prop) {
|
||||
/*
|
||||
* Spread elements have an argument property while
|
||||
* others have a value property. Because different
|
||||
* parsers use different node types for spread elements,
|
||||
* we just check if there is an argument property.
|
||||
*/
|
||||
return hasMemberExpressionAssignment(
|
||||
prop.argument || prop.value,
|
||||
);
|
||||
}
|
||||
switch (node.type) {
|
||||
case "ObjectPattern":
|
||||
return node.properties.some(prop => {
|
||||
if (prop) {
|
||||
|
||||
return false;
|
||||
});
|
||||
/*
|
||||
* Spread elements have an argument property while
|
||||
* others have a value property. Because different
|
||||
* parsers use different node types for spread elements,
|
||||
* we just check if there is an argument property.
|
||||
*/
|
||||
return hasMemberExpressionAssignment(prop.argument || prop.value);
|
||||
}
|
||||
|
||||
case "ArrayPattern":
|
||||
return node.elements.some(element => {
|
||||
if (element) {
|
||||
return hasMemberExpressionAssignment(element);
|
||||
}
|
||||
return false;
|
||||
});
|
||||
|
||||
return false;
|
||||
});
|
||||
case "ArrayPattern":
|
||||
return node.elements.some(element => {
|
||||
if (element) {
|
||||
return hasMemberExpressionAssignment(element);
|
||||
}
|
||||
|
||||
case "AssignmentPattern":
|
||||
return hasMemberExpressionAssignment(node.left);
|
||||
return false;
|
||||
});
|
||||
|
||||
case "MemberExpression":
|
||||
return true;
|
||||
case "AssignmentPattern":
|
||||
return hasMemberExpressionAssignment(node.left);
|
||||
|
||||
// no default
|
||||
}
|
||||
case "MemberExpression":
|
||||
return true;
|
||||
|
||||
return false;
|
||||
// no default
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -176,91 +171,90 @@ function hasMemberExpressionAssignment(node) {
|
||||
* Otherwise, null.
|
||||
*/
|
||||
function getIdentifierIfShouldBeConst(variable, ignoreReadBeforeAssign) {
|
||||
if (variable.eslintUsed && variable.scope.type === "global") {
|
||||
return null;
|
||||
}
|
||||
if (variable.eslintUsed && variable.scope.type === "global") {
|
||||
return null;
|
||||
}
|
||||
|
||||
// Finds the unique WriteReference.
|
||||
let writer = null;
|
||||
let isReadBeforeInit = false;
|
||||
const references = variable.references;
|
||||
// Finds the unique WriteReference.
|
||||
let writer = null;
|
||||
let isReadBeforeInit = false;
|
||||
const references = variable.references;
|
||||
|
||||
for (let i = 0; i < references.length; ++i) {
|
||||
const reference = references[i];
|
||||
for (let i = 0; i < references.length; ++i) {
|
||||
const reference = references[i];
|
||||
|
||||
if (reference.isWrite()) {
|
||||
const isReassigned =
|
||||
writer !== null && writer.identifier !== reference.identifier;
|
||||
if (reference.isWrite()) {
|
||||
const isReassigned = (
|
||||
writer !== null &&
|
||||
writer.identifier !== reference.identifier
|
||||
);
|
||||
|
||||
if (isReassigned) {
|
||||
return null;
|
||||
}
|
||||
if (isReassigned) {
|
||||
return null;
|
||||
}
|
||||
|
||||
const destructuringHost = getDestructuringHost(reference);
|
||||
const destructuringHost = getDestructuringHost(reference);
|
||||
|
||||
if (
|
||||
destructuringHost !== null &&
|
||||
destructuringHost.left !== void 0
|
||||
) {
|
||||
const leftNode = destructuringHost.left;
|
||||
let hasOuterVariables = false,
|
||||
hasNonIdentifiers = false;
|
||||
if (destructuringHost !== null && destructuringHost.left !== void 0) {
|
||||
const leftNode = destructuringHost.left;
|
||||
let hasOuterVariables = false,
|
||||
hasNonIdentifiers = false;
|
||||
|
||||
if (leftNode.type === "ObjectPattern") {
|
||||
const properties = leftNode.properties;
|
||||
if (leftNode.type === "ObjectPattern") {
|
||||
const properties = leftNode.properties;
|
||||
|
||||
hasOuterVariables = properties
|
||||
.filter(prop => prop.value)
|
||||
.map(prop => prop.value.name)
|
||||
.some(name =>
|
||||
isOuterVariableInDestructing(name, variable.scope),
|
||||
);
|
||||
hasOuterVariables = properties
|
||||
.filter(prop => prop.value)
|
||||
.map(prop => prop.value.name)
|
||||
.some(name => isOuterVariableInDestructing(name, variable.scope));
|
||||
|
||||
hasNonIdentifiers = hasMemberExpressionAssignment(leftNode);
|
||||
} else if (leftNode.type === "ArrayPattern") {
|
||||
const elements = leftNode.elements;
|
||||
hasNonIdentifiers = hasMemberExpressionAssignment(leftNode);
|
||||
|
||||
hasOuterVariables = elements
|
||||
.map(element => element && element.name)
|
||||
.some(name =>
|
||||
isOuterVariableInDestructing(name, variable.scope),
|
||||
);
|
||||
} else if (leftNode.type === "ArrayPattern") {
|
||||
const elements = leftNode.elements;
|
||||
|
||||
hasNonIdentifiers = hasMemberExpressionAssignment(leftNode);
|
||||
}
|
||||
hasOuterVariables = elements
|
||||
.map(element => element && element.name)
|
||||
.some(name => isOuterVariableInDestructing(name, variable.scope));
|
||||
|
||||
if (hasOuterVariables || hasNonIdentifiers) {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
hasNonIdentifiers = hasMemberExpressionAssignment(leftNode);
|
||||
}
|
||||
|
||||
writer = reference;
|
||||
} else if (reference.isRead() && writer === null) {
|
||||
if (ignoreReadBeforeAssign) {
|
||||
return null;
|
||||
}
|
||||
isReadBeforeInit = true;
|
||||
}
|
||||
}
|
||||
if (hasOuterVariables || hasNonIdentifiers) {
|
||||
return null;
|
||||
}
|
||||
|
||||
/*
|
||||
* If the assignment is from a different scope, ignore it.
|
||||
* If the assignment cannot change to a declaration, ignore it.
|
||||
*/
|
||||
const shouldBeConst =
|
||||
writer !== null &&
|
||||
writer.from === variable.scope &&
|
||||
canBecomeVariableDeclaration(writer.identifier);
|
||||
}
|
||||
|
||||
if (!shouldBeConst) {
|
||||
return null;
|
||||
}
|
||||
writer = reference;
|
||||
|
||||
if (isReadBeforeInit) {
|
||||
return variable.defs[0].name;
|
||||
}
|
||||
} else if (reference.isRead() && writer === null) {
|
||||
if (ignoreReadBeforeAssign) {
|
||||
return null;
|
||||
}
|
||||
isReadBeforeInit = true;
|
||||
}
|
||||
}
|
||||
|
||||
return writer.identifier;
|
||||
/*
|
||||
* If the assignment is from a different scope, ignore it.
|
||||
* If the assignment cannot change to a declaration, ignore it.
|
||||
*/
|
||||
const shouldBeConst = (
|
||||
writer !== null &&
|
||||
writer.from === variable.scope &&
|
||||
canBecomeVariableDeclaration(writer.identifier)
|
||||
);
|
||||
|
||||
if (!shouldBeConst) {
|
||||
return null;
|
||||
}
|
||||
|
||||
if (isReadBeforeInit) {
|
||||
return variable.defs[0].name;
|
||||
}
|
||||
|
||||
return writer.identifier;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -274,44 +268,41 @@ function getIdentifierIfShouldBeConst(variable, ignoreReadBeforeAssign) {
|
||||
* @returns {Map<ASTNode, ASTNode[]>} Grouped identifier nodes.
|
||||
*/
|
||||
function groupByDestructuring(variables, ignoreReadBeforeAssign) {
|
||||
const identifierMap = new Map();
|
||||
const identifierMap = new Map();
|
||||
|
||||
for (let i = 0; i < variables.length; ++i) {
|
||||
const variable = variables[i];
|
||||
const references = variable.references;
|
||||
const identifier = getIdentifierIfShouldBeConst(
|
||||
variable,
|
||||
ignoreReadBeforeAssign,
|
||||
);
|
||||
let prevId = null;
|
||||
for (let i = 0; i < variables.length; ++i) {
|
||||
const variable = variables[i];
|
||||
const references = variable.references;
|
||||
const identifier = getIdentifierIfShouldBeConst(variable, ignoreReadBeforeAssign);
|
||||
let prevId = null;
|
||||
|
||||
for (let j = 0; j < references.length; ++j) {
|
||||
const reference = references[j];
|
||||
const id = reference.identifier;
|
||||
for (let j = 0; j < references.length; ++j) {
|
||||
const reference = references[j];
|
||||
const id = reference.identifier;
|
||||
|
||||
/*
|
||||
* Avoid counting a reference twice or more for default values of
|
||||
* destructuring.
|
||||
*/
|
||||
if (id === prevId) {
|
||||
continue;
|
||||
}
|
||||
prevId = id;
|
||||
/*
|
||||
* Avoid counting a reference twice or more for default values of
|
||||
* destructuring.
|
||||
*/
|
||||
if (id === prevId) {
|
||||
continue;
|
||||
}
|
||||
prevId = id;
|
||||
|
||||
// Add the identifier node into the destructuring group.
|
||||
const group = getDestructuringHost(reference);
|
||||
// Add the identifier node into the destructuring group.
|
||||
const group = getDestructuringHost(reference);
|
||||
|
||||
if (group) {
|
||||
if (identifierMap.has(group)) {
|
||||
identifierMap.get(group).push(identifier);
|
||||
} else {
|
||||
identifierMap.set(group, [identifier]);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
if (group) {
|
||||
if (identifierMap.has(group)) {
|
||||
identifierMap.get(group).push(identifier);
|
||||
} else {
|
||||
identifierMap.set(group, [identifier]);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return identifierMap;
|
||||
return identifierMap;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -322,225 +313,189 @@ function groupByDestructuring(variables, ignoreReadBeforeAssign) {
|
||||
* @returns {ASTNode} The closest ancestor with the specified type; null if no such ancestor exists.
|
||||
*/
|
||||
function findUp(node, type, shouldStop) {
|
||||
if (!node || shouldStop(node)) {
|
||||
return null;
|
||||
}
|
||||
if (node.type === type) {
|
||||
return node;
|
||||
}
|
||||
return findUp(node.parent, type, shouldStop);
|
||||
if (!node || shouldStop(node)) {
|
||||
return null;
|
||||
}
|
||||
if (node.type === type) {
|
||||
return node;
|
||||
}
|
||||
return findUp(node.parent, type, shouldStop);
|
||||
}
|
||||
|
||||
//------------------------------------------------------------------------------
|
||||
// Rule Definition
|
||||
//------------------------------------------------------------------------------
|
||||
|
||||
/** @type {import('../types').Rule.RuleModule} */
|
||||
/** @type {import('../shared/types').Rule} */
|
||||
module.exports = {
|
||||
meta: {
|
||||
type: "suggestion",
|
||||
meta: {
|
||||
type: "suggestion",
|
||||
|
||||
defaultOptions: [
|
||||
{
|
||||
destructuring: "any",
|
||||
ignoreReadBeforeAssign: false,
|
||||
},
|
||||
],
|
||||
docs: {
|
||||
description: "Require `const` declarations for variables that are never reassigned after declared",
|
||||
recommended: false,
|
||||
url: "https://eslint.org/docs/latest/rules/prefer-const"
|
||||
},
|
||||
|
||||
docs: {
|
||||
description:
|
||||
"Require `const` declarations for variables that are never reassigned after declared",
|
||||
recommended: false,
|
||||
url: "https://eslint.org/docs/latest/rules/prefer-const",
|
||||
},
|
||||
fixable: "code",
|
||||
|
||||
fixable: "code",
|
||||
schema: [
|
||||
{
|
||||
type: "object",
|
||||
properties: {
|
||||
destructuring: { enum: ["any", "all"], default: "any" },
|
||||
ignoreReadBeforeAssign: { type: "boolean", default: false }
|
||||
},
|
||||
additionalProperties: false
|
||||
}
|
||||
],
|
||||
messages: {
|
||||
useConst: "'{{name}}' is never reassigned. Use 'const' instead."
|
||||
}
|
||||
},
|
||||
|
||||
schema: [
|
||||
{
|
||||
type: "object",
|
||||
properties: {
|
||||
destructuring: { enum: ["any", "all"] },
|
||||
ignoreReadBeforeAssign: { type: "boolean" },
|
||||
},
|
||||
additionalProperties: false,
|
||||
},
|
||||
],
|
||||
messages: {
|
||||
useConst: "'{{name}}' is never reassigned. Use 'const' instead.",
|
||||
},
|
||||
},
|
||||
create(context) {
|
||||
const options = context.options[0] || {};
|
||||
const sourceCode = context.sourceCode;
|
||||
const shouldMatchAnyDestructuredVariable = options.destructuring !== "all";
|
||||
const ignoreReadBeforeAssign = options.ignoreReadBeforeAssign === true;
|
||||
const variables = [];
|
||||
let reportCount = 0;
|
||||
let checkedId = null;
|
||||
let checkedName = "";
|
||||
|
||||
create(context) {
|
||||
const [{ destructuring, ignoreReadBeforeAssign }] = context.options;
|
||||
const shouldMatchAnyDestructuredVariable = destructuring !== "all";
|
||||
const sourceCode = context.sourceCode;
|
||||
const variables = [];
|
||||
let reportCount = 0;
|
||||
let checkedId = null;
|
||||
let checkedName = "";
|
||||
|
||||
/**
|
||||
* Reports given identifier nodes if all of the nodes should be declared
|
||||
* as const.
|
||||
*
|
||||
* The argument 'nodes' is an array of Identifier nodes.
|
||||
* This node is the result of 'getIdentifierIfShouldBeConst()', so it's
|
||||
* nullable. In simple declaration or assignment cases, the length of
|
||||
* the array is 1. In destructuring cases, the length of the array can
|
||||
* be 2 or more.
|
||||
* @param {(eslint-scope.Reference|null)[]} nodes
|
||||
* References which are grouped by destructuring to report.
|
||||
* @returns {void}
|
||||
*/
|
||||
function checkGroup(nodes) {
|
||||
const nodesToReport = nodes.filter(Boolean);
|
||||
/**
|
||||
* Reports given identifier nodes if all of the nodes should be declared
|
||||
* as const.
|
||||
*
|
||||
* The argument 'nodes' is an array of Identifier nodes.
|
||||
* This node is the result of 'getIdentifierIfShouldBeConst()', so it's
|
||||
* nullable. In simple declaration or assignment cases, the length of
|
||||
* the array is 1. In destructuring cases, the length of the array can
|
||||
* be 2 or more.
|
||||
* @param {(eslint-scope.Reference|null)[]} nodes
|
||||
* References which are grouped by destructuring to report.
|
||||
* @returns {void}
|
||||
*/
|
||||
function checkGroup(nodes) {
|
||||
const nodesToReport = nodes.filter(Boolean);
|
||||
|
||||
if (
|
||||
nodes.length &&
|
||||
(shouldMatchAnyDestructuredVariable ||
|
||||
nodesToReport.length === nodes.length)
|
||||
) {
|
||||
const varDeclParent = findUp(
|
||||
nodes[0],
|
||||
"VariableDeclaration",
|
||||
parentNode => parentNode.type.endsWith("Statement"),
|
||||
);
|
||||
const isVarDecParentNull = varDeclParent === null;
|
||||
if (nodes.length && (shouldMatchAnyDestructuredVariable || nodesToReport.length === nodes.length)) {
|
||||
const varDeclParent = findUp(nodes[0], "VariableDeclaration", parentNode => parentNode.type.endsWith("Statement"));
|
||||
const isVarDecParentNull = varDeclParent === null;
|
||||
|
||||
if (
|
||||
!isVarDecParentNull &&
|
||||
varDeclParent.declarations.length > 0
|
||||
) {
|
||||
const firstDeclaration = varDeclParent.declarations[0];
|
||||
if (!isVarDecParentNull && varDeclParent.declarations.length > 0) {
|
||||
const firstDeclaration = varDeclParent.declarations[0];
|
||||
|
||||
if (firstDeclaration.init) {
|
||||
const firstDecParent = firstDeclaration.init.parent;
|
||||
if (firstDeclaration.init) {
|
||||
const firstDecParent = firstDeclaration.init.parent;
|
||||
|
||||
/*
|
||||
* First we check the declaration type and then depending on
|
||||
* if the type is a "VariableDeclarator" or its an "ObjectPattern"
|
||||
* we compare the name and id from the first identifier, if the names are different
|
||||
* we assign the new name, id and reset the count of reportCount and nodeCount in
|
||||
* order to check each block for the number of reported errors and base our fix
|
||||
* based on comparing nodes.length and nodesToReport.length.
|
||||
*/
|
||||
/*
|
||||
* First we check the declaration type and then depending on
|
||||
* if the type is a "VariableDeclarator" or its an "ObjectPattern"
|
||||
* we compare the name and id from the first identifier, if the names are different
|
||||
* we assign the new name, id and reset the count of reportCount and nodeCount in
|
||||
* order to check each block for the number of reported errors and base our fix
|
||||
* based on comparing nodes.length and nodesToReport.length.
|
||||
*/
|
||||
|
||||
if (firstDecParent.type === "VariableDeclarator") {
|
||||
if (firstDecParent.id.name !== checkedName) {
|
||||
checkedName = firstDecParent.id.name;
|
||||
reportCount = 0;
|
||||
}
|
||||
if (firstDecParent.type === "VariableDeclarator") {
|
||||
|
||||
if (firstDecParent.id.type === "ObjectPattern") {
|
||||
if (firstDecParent.init.name !== checkedName) {
|
||||
checkedName = firstDecParent.init.name;
|
||||
reportCount = 0;
|
||||
}
|
||||
}
|
||||
if (firstDecParent.id.name !== checkedName) {
|
||||
checkedName = firstDecParent.id.name;
|
||||
reportCount = 0;
|
||||
}
|
||||
|
||||
if (firstDecParent.id !== checkedId) {
|
||||
checkedId = firstDecParent.id;
|
||||
reportCount = 0;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
if (firstDecParent.id.type === "ObjectPattern") {
|
||||
if (firstDecParent.init.name !== checkedName) {
|
||||
checkedName = firstDecParent.init.name;
|
||||
reportCount = 0;
|
||||
}
|
||||
}
|
||||
|
||||
let shouldFix =
|
||||
varDeclParent &&
|
||||
// Don't do a fix unless all variables in the declarations are initialized (or it's in a for-in or for-of loop)
|
||||
(varDeclParent.parent.type === "ForInStatement" ||
|
||||
varDeclParent.parent.type === "ForOfStatement" ||
|
||||
varDeclParent.declarations.every(
|
||||
declaration => declaration.init,
|
||||
)) &&
|
||||
/*
|
||||
* If options.destructuring is "all", then this warning will not occur unless
|
||||
* every assignment in the destructuring should be const. In that case, it's safe
|
||||
* to apply the fix.
|
||||
*/
|
||||
nodesToReport.length === nodes.length;
|
||||
if (firstDecParent.id !== checkedId) {
|
||||
checkedId = firstDecParent.id;
|
||||
reportCount = 0;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (
|
||||
!isVarDecParentNull &&
|
||||
varDeclParent.declarations &&
|
||||
varDeclParent.declarations.length !== 1
|
||||
) {
|
||||
if (
|
||||
varDeclParent &&
|
||||
varDeclParent.declarations &&
|
||||
varDeclParent.declarations.length >= 1
|
||||
) {
|
||||
/*
|
||||
* Add nodesToReport.length to a count, then comparing the count to the length
|
||||
* of the declarations in the current block.
|
||||
*/
|
||||
let shouldFix = varDeclParent &&
|
||||
|
||||
reportCount += nodesToReport.length;
|
||||
// Don't do a fix unless all variables in the declarations are initialized (or it's in a for-in or for-of loop)
|
||||
(varDeclParent.parent.type === "ForInStatement" || varDeclParent.parent.type === "ForOfStatement" ||
|
||||
varDeclParent.declarations.every(declaration => declaration.init)) &&
|
||||
|
||||
let totalDeclarationsCount = 0;
|
||||
/*
|
||||
* If options.destructuring is "all", then this warning will not occur unless
|
||||
* every assignment in the destructuring should be const. In that case, it's safe
|
||||
* to apply the fix.
|
||||
*/
|
||||
nodesToReport.length === nodes.length;
|
||||
|
||||
varDeclParent.declarations.forEach(declaration => {
|
||||
if (declaration.id.type === "ObjectPattern") {
|
||||
totalDeclarationsCount +=
|
||||
declaration.id.properties.length;
|
||||
} else if (declaration.id.type === "ArrayPattern") {
|
||||
totalDeclarationsCount +=
|
||||
declaration.id.elements.length;
|
||||
} else {
|
||||
totalDeclarationsCount += 1;
|
||||
}
|
||||
});
|
||||
if (!isVarDecParentNull && varDeclParent.declarations && varDeclParent.declarations.length !== 1) {
|
||||
|
||||
shouldFix =
|
||||
shouldFix && reportCount === totalDeclarationsCount;
|
||||
}
|
||||
}
|
||||
if (varDeclParent && varDeclParent.declarations && varDeclParent.declarations.length >= 1) {
|
||||
|
||||
nodesToReport.forEach(node => {
|
||||
context.report({
|
||||
node,
|
||||
messageId: "useConst",
|
||||
data: node,
|
||||
fix: shouldFix
|
||||
? fixer => {
|
||||
const letKeywordToken =
|
||||
sourceCode.getFirstToken(
|
||||
varDeclParent,
|
||||
t => t.value === varDeclParent.kind,
|
||||
);
|
||||
/*
|
||||
* Add nodesToReport.length to a count, then comparing the count to the length
|
||||
* of the declarations in the current block.
|
||||
*/
|
||||
|
||||
/**
|
||||
* Extend the replacement range to the whole declaration,
|
||||
* in order to prevent other fixes in the same pass
|
||||
* https://github.com/eslint/eslint/issues/13899
|
||||
*/
|
||||
return new FixTracker(fixer, sourceCode)
|
||||
.retainRange(varDeclParent.range)
|
||||
.replaceTextRange(
|
||||
letKeywordToken.range,
|
||||
"const",
|
||||
);
|
||||
}
|
||||
: null,
|
||||
});
|
||||
});
|
||||
}
|
||||
}
|
||||
reportCount += nodesToReport.length;
|
||||
|
||||
return {
|
||||
"Program:exit"() {
|
||||
groupByDestructuring(variables, ignoreReadBeforeAssign).forEach(
|
||||
checkGroup,
|
||||
);
|
||||
},
|
||||
let totalDeclarationsCount = 0;
|
||||
|
||||
VariableDeclaration(node) {
|
||||
if (node.kind === "let" && !isInitOfForStatement(node)) {
|
||||
variables.push(...sourceCode.getDeclaredVariables(node));
|
||||
}
|
||||
},
|
||||
};
|
||||
},
|
||||
varDeclParent.declarations.forEach(declaration => {
|
||||
if (declaration.id.type === "ObjectPattern") {
|
||||
totalDeclarationsCount += declaration.id.properties.length;
|
||||
} else if (declaration.id.type === "ArrayPattern") {
|
||||
totalDeclarationsCount += declaration.id.elements.length;
|
||||
} else {
|
||||
totalDeclarationsCount += 1;
|
||||
}
|
||||
});
|
||||
|
||||
shouldFix = shouldFix && (reportCount === totalDeclarationsCount);
|
||||
}
|
||||
}
|
||||
|
||||
nodesToReport.forEach(node => {
|
||||
context.report({
|
||||
node,
|
||||
messageId: "useConst",
|
||||
data: node,
|
||||
fix: shouldFix
|
||||
? fixer => {
|
||||
const letKeywordToken = sourceCode.getFirstToken(varDeclParent, t => t.value === varDeclParent.kind);
|
||||
|
||||
/**
|
||||
* Extend the replacement range to the whole declaration,
|
||||
* in order to prevent other fixes in the same pass
|
||||
* https://github.com/eslint/eslint/issues/13899
|
||||
*/
|
||||
return new FixTracker(fixer, sourceCode)
|
||||
.retainRange(varDeclParent.range)
|
||||
.replaceTextRange(letKeywordToken.range, "const");
|
||||
}
|
||||
: null
|
||||
});
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
return {
|
||||
"Program:exit"() {
|
||||
groupByDestructuring(variables, ignoreReadBeforeAssign).forEach(checkGroup);
|
||||
},
|
||||
|
||||
VariableDeclaration(node) {
|
||||
if (node.kind === "let" && !isInitOfForStatement(node)) {
|
||||
variables.push(...sourceCode.getDeclaredVariables(node));
|
||||
}
|
||||
}
|
||||
};
|
||||
}
|
||||
};
|
||||
Reference in new issue
Block a user