From 014c24b8cf70c2e99d4efd6a619e258629ac90c5 Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Fri, 24 Nov 2023 15:54:27 -0800
Subject: [PATCH] Fix loading indicator

---
 .../document-detail/document-detail.component.html         | 3 +--
 .../document-detail/document-detail.component.ts           | 7 -------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/src-ui/src/app/components/document-detail/document-detail.component.html b/src-ui/src/app/components/document-detail/document-detail.component.html
index 9883bb39b..8d31f8f8e 100644
--- a/src-ui/src/app/components/document-detail/document-detail.component.html
+++ b/src-ui/src/app/components/document-detail/document-detail.component.html
@@ -240,7 +240,7 @@
 </div>
 
 <ng-template #previewContent>
-    <div *ngIf="previewLoading" class="w-100 h-100 d-flex align-items-center justify-content-center">
+    <div *ngIf="!metadata" class="w-100 h-100 d-flex align-items-center justify-content-center">
         <div>
             <div class="spinner-border spinner-border-sm me-2" role="status"></div>
             <ng-container i18n>Loading...</ng-container>
@@ -255,7 +255,6 @@
                 [showBorders]="false"
                 [zoom]="previewZoomSetting"
                 (pagesLoaded)="onPagesLoaded($event)"
-                (pdfLoadingStarts)="onPdfLoadingStarts()"
                 (pdfLoadingFailed)="onPdfLoadingFailed($event)"
                 (beforePrint)="onBeforePrint()"
                 (afterPrint)="onAfterPrint()"
diff --git a/src-ui/src/app/components/document-detail/document-detail.component.ts b/src-ui/src/app/components/document-detail/document-detail.component.ts
index 6196911e1..52655e733 100644
--- a/src-ui/src/app/components/document-detail/document-detail.component.ts
+++ b/src-ui/src/app/components/document-detail/document-detail.component.ts
@@ -157,7 +157,6 @@ export class DocumentDetailComponent
   previewCurrentPage: number = 1
   previewNumPages: number = 1
   previewZoomSetting: ZoomSetting = ZoomSetting.Width
-  previewLoading: boolean = true
 
   printLoadingModal: NgbModalRef
 
@@ -451,8 +450,6 @@ export class DocumentDetailComponent
       .subscribe({
         next: (result) => {
           this.metadata = result
-          if (this.getContentType() !== 'application/pdf')
-            this.previewLoading = false
         },
         error: (error) => {
           this.metadata = null
@@ -774,10 +771,6 @@ export class DocumentDetailComponent
       })
   }
 
-  onPdfLoadingStarts() {
-    this.previewLoading = false
-  }
-
   onPagesLoaded(event: PagesLoadedEvent) {
     this.previewNumPages = event.pagesCount
   }