From 09a3445999ff88f13a3b18e008e19193e979e2f0 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Sun, 15 Sep 2024 21:20:45 -0700 Subject: [PATCH] Fix remove --- .../custom-fields-query-dropdown.component.spec.ts | 4 ++-- .../custom-fields-query-dropdown.component.ts | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src-ui/src/app/components/common/custom-fields-query-dropdown/custom-fields-query-dropdown.component.spec.ts b/src-ui/src/app/components/common/custom-fields-query-dropdown/custom-fields-query-dropdown.component.spec.ts index 4b3c1e9e1..e5ceb8dec 100644 --- a/src-ui/src/app/components/common/custom-fields-query-dropdown/custom-fields-query-dropdown.component.spec.ts +++ b/src-ui/src/app/components/common/custom-fields-query-dropdown/custom-fields-query-dropdown.component.spec.ts @@ -281,10 +281,10 @@ describe('CustomFieldsQueryDropdownComponent', () => { [4, 'icontains', 'test'], ], ]) - expression2.addAtom(atom) + expression.addAtom(atom) expression2.addExpression(expression) model.addExpression(expression2) - model.removeElement(expression) + model.removeElement(atom) expect(model.queries.length).toBe(1) model.removeElement(expression2) }) diff --git a/src-ui/src/app/components/common/custom-fields-query-dropdown/custom-fields-query-dropdown.component.ts b/src-ui/src/app/components/common/custom-fields-query-dropdown/custom-fields-query-dropdown.component.ts index e2228bd57..b1a6befb5 100644 --- a/src-ui/src/app/components/common/custom-fields-query-dropdown/custom-fields-query-dropdown.component.ts +++ b/src-ui/src/app/components/common/custom-fields-query-dropdown/custom-fields-query-dropdown.component.ts @@ -103,6 +103,11 @@ export class CustomFieldQueriesModel { for (let i = 0; i < elements.length; i++) { if (elements[i] === queryElement) { return elements.splice(i, 1)[0] + } else if (elements[i].type === CustomFieldQueryElementType.Expression) { + return this.findElement( + queryElement, + elements[i].value as CustomFieldQueryElement[] + ) } } }