From 0cc773f9414128428759fd1273cd224286948708 Mon Sep 17 00:00:00 2001
From: Pascal Krahmer <5699756+pkrahmer@users.noreply.github.com>
Date: Sun, 4 Feb 2024 23:02:51 +0100
Subject: [PATCH] review comments

---
 src/documents/barcodes.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/documents/barcodes.py b/src/documents/barcodes.py
index 2b36b697f..4bfb9b791 100644
--- a/src/documents/barcodes.py
+++ b/src/documents/barcodes.py
@@ -309,10 +309,9 @@ class BarcodePlugin(ConsumeTaskPlugin):
             for raw in tag_texts.split(","):
                 try:
                     tag = None
-
-                    mappings = settings.CONSUMER_TAG_BARCODE_MAPPING.items()
-                    for regex, sub in mappings:
+                    for regex in settings.CONSUMER_TAG_BARCODE_MAPPING:
                         if re.match(regex, raw, flags=re.IGNORECASE):
+                            sub = settings.CONSUMER_TAG_BARCODE_MAPPING[regex]
                             tag = (
                                 re.sub(regex, sub, raw, flags=re.IGNORECASE)
                                 if sub