From 2d09a8d7351b40d3e93d86e12250454f7cebde9e Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue, 19 Dec 2023 08:04:42 -0800 Subject: [PATCH] Implement suggestions from code review --- src/documents/tests/test_api_permissions.py | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/documents/tests/test_api_permissions.py b/src/documents/tests/test_api_permissions.py index 9a32a6a67..a0b22586b 100644 --- a/src/documents/tests/test_api_permissions.py +++ b/src/documents/tests/test_api_permissions.py @@ -433,17 +433,11 @@ class TestApiAuth(DirectoriesMixin, APITestCase): self.assertNotIn("permissions", resp_data["results"][0]) self.assertIn("user_can_change", resp_data["results"][0]) - self.assertEqual(resp_data["results"][0]["user_can_change"], True) # doc1 - self.assertEqual( - resp_data["results"][0]["is_shared_by_requester"], - False, - ) # doc1 - self.assertEqual(resp_data["results"][1]["user_can_change"], False) # doc2 - self.assertEqual(resp_data["results"][2]["user_can_change"], True) # doc3 - self.assertEqual( - resp_data["results"][3]["is_shared_by_requester"], - True, - ) # doc4 + self.assertTrue(resp_data["results"][0]["user_can_change"]) # doc1 + self.assertFalse(resp_data["results"][0]["is_shared_by_requester"]) # doc1 + self.assertFalse(resp_data["results"][1]["user_can_change"]) # doc2 + self.assertTrue(resp_data["results"][2]["user_can_change"]) # doc3 + self.assertTrue(resp_data["results"][3]["is_shared_by_requester"]) # doc4 response = self.client.get( "/api/documents/?full_perms=true",