From 33e8f9d6ba4ef6ae8e7684e1364bc91272aaf5d1 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Fri, 19 Apr 2024 01:10:47 -0700 Subject: [PATCH] Remove unneeded http method check --- src/documents/views.py | 65 +++++++++++++++++++++--------------------- 1 file changed, 32 insertions(+), 33 deletions(-) diff --git a/src/documents/views.py b/src/documents/views.py index 27872f93e..817dbcc23 100644 --- a/src/documents/views.py +++ b/src/documents/views.py @@ -746,49 +746,48 @@ class DocumentViewSet( except Document.DoesNotExist: # pragma: no cover raise Http404 - if request.method == "GET": - # documents - entries = [ + # documents + entries = [ + { + "id": entry.id, + "timestamp": entry.timestamp, + "action": entry.get_action_display(), + "changes": entry.changes, + "actor": ( + {"id": entry.actor.id, "username": entry.actor.username} + if entry.actor + else None + ), + } + for entry in LogEntry.objects.filter(object_pk=doc.pk) + ] + + # custom fields + for entry in LogEntry.objects.filter( + object_pk__in=doc.custom_fields.values_list("id", flat=True), + content_type=ContentType.objects.get_for_model(CustomFieldInstance), + ): + entries.append( { "id": entry.id, "timestamp": entry.timestamp, "action": entry.get_action_display(), - "changes": entry.changes, + "changes": { + "custom_fields": { + "type": "custom_field", + "field": str(entry.object_repr).split(":")[0].strip(), + "value": str(entry.object_repr).split(":")[1].strip(), + }, + }, "actor": ( {"id": entry.actor.id, "username": entry.actor.username} if entry.actor else None ), - } - for entry in LogEntry.objects.filter(object_pk=doc.pk) - ] + }, + ) - # custom fields - for entry in LogEntry.objects.filter( - object_pk__in=doc.custom_fields.values_list("id", flat=True), - content_type=ContentType.objects.get_for_model(CustomFieldInstance), - ): - entries.append( - { - "id": entry.id, - "timestamp": entry.timestamp, - "action": entry.get_action_display(), - "changes": { - "custom_fields": { - "type": "custom_field", - "field": str(entry.object_repr).split(":")[0].strip(), - "value": str(entry.object_repr).split(":")[1].strip(), - }, - }, - "actor": ( - {"id": entry.actor.id, "username": entry.actor.username} - if entry.actor - else None - ), - }, - ) - - return Response(sorted(entries, key=lambda x: x["timestamp"], reverse=True)) + return Response(sorted(entries, key=lambda x: x["timestamp"], reverse=True)) class SearchResultSerializer(DocumentSerializer, PassUserMixin):