From 63157583f3a98af44856c9b7f8db93f7f642cb51 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Thu, 4 Apr 2024 23:45:34 -0700 Subject: [PATCH] Blur filter editor on escape when empty --- .../filter-editor/filter-editor.component.spec.ts | 5 +++++ .../filter-editor/filter-editor.component.ts | 8 ++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.spec.ts b/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.spec.ts index e091dbf15..d9e92092e 100644 --- a/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.spec.ts +++ b/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.spec.ts @@ -1814,6 +1814,11 @@ describe('FilterEditorComponent', () => { new KeyboardEvent('keyup', { key: 'Escape' }) ) expect(component.textFilter).toEqual('') + const blurSpy = jest.spyOn(component.textFilterInput.nativeElement, 'blur') + component.textFilterInput.nativeElement.dispatchEvent( + new KeyboardEvent('keyup', { key: 'Escape' }) + ) + expect(blurSpy).toHaveBeenCalled() }) it('should adjust text filter targets if more like search', () => { diff --git a/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.ts b/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.ts index a6aafe049..7926ce48d 100644 --- a/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.ts +++ b/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.ts @@ -975,8 +975,12 @@ export class FilterEditorComponent if (filterString.length) { this.updateTextFilter(filterString) } - } else if (event.key == 'Escape') { - this.resetTextField() + } else if (event.key === 'Escape') { + if (this._textFilter?.length) { + this.resetTextField() + } else { + this.textFilterInput.nativeElement.blur() + } } }