lgcosta/paperless-ngx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Increased test coverage

Browse Source
This commit is contained in:
Pascal Krahmer 2024-01-29 16:07:58 +01:00
parent fbc7011b6f
commit 6624d6144b
2 changed files with 24 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/documents/barcodes.py
View File

@ -333,8 +333,8 @@ class BarcodePlugin(ConsumeTaskPlugin):
) )
tags.append(tag.pk) tags.append(tag.pk)
except ValueError as e: except Exception as e:
logger.warning( logger.error(
f"Failed to find or create TAG '{raw}' because: {e}", f"Failed to find or create TAG '{raw}' because: {e}",
) )

24
src/documents/tests/test_barcodes.py
View File

@ -812,11 +812,13 @@ class TestTagBarcode(DirectoriesMixin, SampleDirMixin, GetReaderPluginMixin, Tes
""" """
test_file = self.BARCODE_SAMPLE_DIR / "barcode-39-asn-custom-prefix.pdf" test_file = self.BARCODE_SAMPLE_DIR / "barcode-39-asn-custom-prefix.pdf"
with self.get_reader(test_file) as reader: with self.get_reader(test_file) as reader:
reader.metadata.tag_ids = [99]
reader.run() reader.run()
self.assertEqual(reader.pdf_file, test_file) self.assertEqual(reader.pdf_file, test_file)
tags = reader.metadata.tag_ids tags = reader.metadata.tag_ids
self.assertEqual(len(tags), 1) self.assertEqual(len(tags), 2)
self.assertEqual(Tag.objects.get(name__iexact="00123").pk, tags[0]) self.assertEqual(tags[0], 99)
self.assertEqual(Tag.objects.get(name__iexact="00123").pk, tags[1])
@override_settings( @override_settings(
CONSUMER_ENABLE_TAG_BARCODE=True, CONSUMER_ENABLE_TAG_BARCODE=True,
@ -844,3 +846,21 @@ class TestTagBarcode(DirectoriesMixin, SampleDirMixin, GetReaderPluginMixin, Tes
self.assertEqual(Tag.objects.get(name__iexact="00125").pk, tags[2]) self.assertEqual(Tag.objects.get(name__iexact="00125").pk, tags[2])
self.assertEqual(Tag.objects.get(name__iexact="00126").pk, tags[3]) self.assertEqual(Tag.objects.get(name__iexact="00126").pk, tags[3])
self.assertEqual(Tag.objects.get(name__iexact="00127").pk, tags[4]) self.assertEqual(Tag.objects.get(name__iexact="00127").pk, tags[4])
@override_settings(
CONSUMER_ENABLE_TAG_BARCODE=True,
CONSUMER_TAG_BARCODE_MAPPING={"CUSTOM-PREFIX-(.*)": "\\g<3>"},
)
def test_scan_file_for_tag_raises_value_error(self):
"""
GIVEN:
- Any error occurs during tag barcode processing
THEN:
- The processing should be skipped and not break the import
"""
test_file = self.BARCODE_SAMPLE_DIR / "barcode-39-asn-custom-prefix.pdf"
with self.get_reader(test_file) as reader:
reader.run()
# expect error to be caught and logged only
tags = reader.metadata.tag_ids
self.assertEqual(tags, None)