From 9818a4c38d8407882487a5ffc60dfcb3f3db4879 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Fri, 1 Nov 2024 15:21:20 -0700 Subject: [PATCH] Change output name --- .../filterable-dropdown.component.html | 2 +- ...ggleable-dropdown-button.component.spec.ts | 4 ++-- .../toggleable-dropdown-button.component.ts | 4 ++-- .../filter-editor.component.spec.ts | 24 +++++++++---------- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src-ui/src/app/components/common/filterable-dropdown/filterable-dropdown.component.html b/src-ui/src/app/components/common/filterable-dropdown/filterable-dropdown.component.html index 413ed8d3b..2ef970801 100644 --- a/src-ui/src/app/components/common/filterable-dropdown/filterable-dropdown.component.html +++ b/src-ui/src/app/components/common/filterable-dropdown/filterable-dropdown.component.html @@ -38,7 +38,7 @@ @for (item of selectionModel.itemsSorted | filter: filterText:'name'; track item; let i = $index) { @if (allowSelectNone || item.id) { + [item]="item" [hideCount]="hideCount(item)" [state]="selectionModel.get(item.id)" [count]="getUpdatedDocumentCount(item.id)" (toggled)="selectionModel.toggle(item.id)" (exclude)="excludeClicked(item.id)" (click)="setButtonItemIndex(i - 1)" [disabled]="disabled"> } } diff --git a/src-ui/src/app/components/common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component.spec.ts b/src-ui/src/app/components/common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component.spec.ts index 379fc591d..52bd36e0f 100644 --- a/src-ui/src/app/components/common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component.spec.ts +++ b/src-ui/src/app/components/common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component.spec.ts @@ -58,7 +58,7 @@ describe('ToggleableDropdownButtonComponent', () => { let toggleResult component.state = ToggleableItemState.Selected component.exclude.subscribe(() => (excludeResult = true)) - component.toggle.subscribe(() => (toggleResult = true)) + component.toggled.subscribe(() => (toggleResult = true)) const button = fixture.nativeElement.querySelector('button') button.dispatchEvent(new MouseEvent('click')) expect(excludeResult).toBeTruthy() @@ -70,7 +70,7 @@ describe('ToggleableDropdownButtonComponent', () => { let toggleResult component.state = ToggleableItemState.Excluded component.exclude.subscribe(() => (excludeResult = true)) - component.toggle.subscribe(() => (toggleResult = true)) + component.toggled.subscribe(() => (toggleResult = true)) const button = fixture.nativeElement.querySelector('button') button.dispatchEvent(new MouseEvent('click')) expect(excludeResult).toBeFalsy() diff --git a/src-ui/src/app/components/common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component.ts b/src-ui/src/app/components/common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component.ts index a450060d6..b3e18cf50 100644 --- a/src-ui/src/app/components/common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component.ts +++ b/src-ui/src/app/components/common/filterable-dropdown/toggleable-dropdown-button/toggleable-dropdown-button.component.ts @@ -30,7 +30,7 @@ export class ToggleableDropdownButtonComponent { hideCount: boolean = false @Output() - toggle = new EventEmitter() + toggled = new EventEmitter() @Output() exclude = new EventEmitter() @@ -43,7 +43,7 @@ export class ToggleableDropdownButtonComponent { if (this.state == ToggleableItemState.Selected) { this.exclude.emit() } else { - this.toggle.emit() + this.toggled.emit() } } diff --git a/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.spec.ts b/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.spec.ts index 402465d1b..7df942a2c 100644 --- a/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.spec.ts +++ b/src-ui/src/app/components/document-list/filter-editor/filter-editor.component.spec.ts @@ -1204,7 +1204,7 @@ describe('FilterEditorComponent', () => { const tagButton = tagsFilterableDropdown.queryAll( By.directive(ToggleableDropdownButtonComponent) )[0] - tagButton.triggerEventHandler('toggle') + tagButton.triggerEventHandler('toggled') fixture.detectChanges() expect(component.filterRules).toEqual([ { @@ -1222,8 +1222,8 @@ describe('FilterEditorComponent', () => { const tagButtons = tagsFilterableDropdown.queryAll( By.directive(ToggleableDropdownButtonComponent) ) - tagButtons[1].triggerEventHandler('toggle') - tagButtons[2].triggerEventHandler('toggle') + tagButtons[1].triggerEventHandler('toggled') + tagButtons[2].triggerEventHandler('toggled') fixture.detectChanges() expect(component.filterRules).toEqual([ { @@ -1273,8 +1273,8 @@ describe('FilterEditorComponent', () => { const correspondentButtons = correspondentsFilterableDropdown.queryAll( By.directive(ToggleableDropdownButtonComponent) ) - correspondentButtons[1].triggerEventHandler('toggle') - correspondentButtons[2].triggerEventHandler('toggle') + correspondentButtons[1].triggerEventHandler('toggled') + correspondentButtons[2].triggerEventHandler('toggled') fixture.detectChanges() expect(component.filterRules).toEqual([ { @@ -1312,7 +1312,7 @@ describe('FilterEditorComponent', () => { const notAssignedButton = correspondentsFilterableDropdown.queryAll( By.directive(ToggleableDropdownButtonComponent) )[0] - notAssignedButton.triggerEventHandler('toggle') + notAssignedButton.triggerEventHandler('toggled') fixture.detectChanges() expect(component.filterRules).toEqual([ { @@ -1330,8 +1330,8 @@ describe('FilterEditorComponent', () => { const documentTypeButtons = documentTypesFilterableDropdown.queryAll( By.directive(ToggleableDropdownButtonComponent) ) - documentTypeButtons[1].triggerEventHandler('toggle') - documentTypeButtons[2].triggerEventHandler('toggle') + documentTypeButtons[1].triggerEventHandler('toggled') + documentTypeButtons[2].triggerEventHandler('toggled') fixture.detectChanges() expect(component.filterRules).toEqual([ { @@ -1369,7 +1369,7 @@ describe('FilterEditorComponent', () => { const notAssignedButton = docTypesFilterableDropdown.queryAll( By.directive(ToggleableDropdownButtonComponent) )[0] - notAssignedButton.triggerEventHandler('toggle') + notAssignedButton.triggerEventHandler('toggled') fixture.detectChanges() expect(component.filterRules).toEqual([ { @@ -1387,8 +1387,8 @@ describe('FilterEditorComponent', () => { const storagePathButtons = storagePathFilterableDropdown.queryAll( By.directive(ToggleableDropdownButtonComponent) ) - storagePathButtons[1].triggerEventHandler('toggle') - storagePathButtons[2].triggerEventHandler('toggle') + storagePathButtons[1].triggerEventHandler('toggled') + storagePathButtons[2].triggerEventHandler('toggled') fixture.detectChanges() expect(component.filterRules).toEqual([ { @@ -1426,7 +1426,7 @@ describe('FilterEditorComponent', () => { const notAssignedButton = storagePathsFilterableDropdown.queryAll( By.directive(ToggleableDropdownButtonComponent) )[0] - notAssignedButton.triggerEventHandler('toggle') + notAssignedButton.triggerEventHandler('toggled') fixture.detectChanges() expect(component.filterRules).toEqual([ {