From 99d1de543ca0a8faa03688c0177dcb5805f37690 Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Fri, 3 Nov 2023 00:26:32 -0700
Subject: [PATCH] Respect permissions for customfielddropdown

---
 .../custom-fields-dropdown.component.html         |  3 ++-
 .../custom-fields-dropdown.component.ts           | 15 ++++++++++++++-
 .../common/input/select/select.component.ts       |  5 ++++-
 .../document-detail.component.html                |  1 +
 4 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/src-ui/src/app/components/common/custom-fields-dropdown/custom-fields-dropdown.component.html b/src-ui/src/app/components/common/custom-fields-dropdown/custom-fields-dropdown.component.html
index f3475c297..e0d26bfc3 100644
--- a/src-ui/src/app/components/common/custom-fields-dropdown/custom-fields-dropdown.component.html
+++ b/src-ui/src/app/components/common/custom-fields-dropdown/custom-fields-dropdown.component.html
@@ -14,11 +14,12 @@
                     [(ngModel)]="field"
                     [placeholder]="placeholderText"
                     [notFoundText]="notFoundText"
+                    [disableCreateNew]="!canCreateFields"
                     (createNew)="createField($event)"
                     bindValue="id">
                 </pngx-input-select>
                 <div class="btn-toolbar" role="toolbar">
-                    <button class="btn btn-sm btn-outline-secondary me-auto" type="button" (click)="createField()">
+                    <button class="btn btn-sm btn-outline-secondary me-auto" type="button" (click)="createField()" [disabled]="!canCreateFields">
                         <svg fill="currentColor" class="buttonicon-sm me-1 mb-1">
                         <use xlink:href="assets/bootstrap-icons.svg#asterisk"/>
                         </svg><ng-container i18n>Create New Field</ng-container>
diff --git a/src-ui/src/app/components/common/custom-fields-dropdown/custom-fields-dropdown.component.ts b/src-ui/src/app/components/common/custom-fields-dropdown/custom-fields-dropdown.component.ts
index 12c51133d..deab5d6f3 100644
--- a/src-ui/src/app/components/common/custom-fields-dropdown/custom-fields-dropdown.component.ts
+++ b/src-ui/src/app/components/common/custom-fields-dropdown/custom-fields-dropdown.component.ts
@@ -12,6 +12,11 @@ import { PaperlessCustomFieldInstance } from 'src/app/data/paperless-custom-fiel
 import { CustomFieldsService } from 'src/app/services/rest/custom-fields.service'
 import { ToastService } from 'src/app/services/toast.service'
 import { CustomFieldEditDialogComponent } from '../edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component'
+import {
+  PermissionAction,
+  PermissionType,
+  PermissionsService,
+} from 'src/app/services/permissions.service'
 
 @Component({
   selector: 'pngx-custom-fields-dropdown',
@@ -48,10 +53,18 @@ export class CustomFieldsDropdownComponent implements OnDestroy {
     return $localize`No unused fields found`
   }
 
+  get canCreateFields(): boolean {
+    return this.permissionsService.currentUserCan(
+      PermissionAction.Add,
+      PermissionType.CustomField
+    )
+  }
+
   constructor(
     private customFieldsService: CustomFieldsService,
     private modalService: NgbModal,
-    private toastService: ToastService
+    private toastService: ToastService,
+    private permissionsService: PermissionsService
   ) {
     this.getFields()
   }
diff --git a/src-ui/src/app/components/common/input/select/select.component.ts b/src-ui/src/app/components/common/input/select/select.component.ts
index fafedee71..76acf31dc 100644
--- a/src-ui/src/app/components/common/input/select/select.component.ts
+++ b/src-ui/src/app/components/common/input/select/select.component.ts
@@ -91,6 +91,9 @@ export class SelectComponent extends AbstractInputComponent<number> {
   @Input()
   notFoundText: string = $localize`No items found`
 
+  @Input()
+  disableCreateNew: boolean = false
+
   @Output()
   createNew = new EventEmitter<string>()
 
@@ -102,7 +105,7 @@ export class SelectComponent extends AbstractInputComponent<number> {
   private _lastSearchTerm: string
 
   get allowCreateNew(): boolean {
-    return this.createNew.observers.length > 0
+    return !this.disableCreateNew && this.createNew.observers.length > 0
   }
 
   get isPrivate(): boolean {
diff --git a/src-ui/src/app/components/document-detail/document-detail.component.html b/src-ui/src/app/components/document-detail/document-detail.component.html
index 6637969e1..a6632e853 100644
--- a/src-ui/src/app/components/document-detail/document-detail.component.html
+++ b/src-ui/src/app/components/document-detail/document-detail.component.html
@@ -49,6 +49,7 @@
     </div>
 
     <pngx-custom-fields-dropdown
+        *pngxIfPermissions="{ action: PermissionAction.View, type: PermissionType.CustomField }"
         class="me-2"
         [documentId]="documentId"
         [disabled]="!userIsOwner"