Refactor dashboard_view_table_columns to document_display_fields

This commit is contained in:
shamoon
2024-04-17 17:58:40 -07:00
parent cd4cc4d9e1
commit 9decfbfcf2
14 changed files with 32 additions and 32 deletions

View File

@@ -34,7 +34,7 @@ class Migration(migrations.Migration):
),
migrations.AddField(
model_name="savedview",
name="dashboard_view_table_columns",
name="document_display_fields",
field=multiselectfield.db.fields.MultiSelectField(
choices=[
("title", "Title"),

View File

@@ -598,9 +598,9 @@ class SavedView(ModelWithOwner):
default=DashboardViewDisplayMode.TABLE,
)
dashboard_view_table_columns = DynamicMultiSelectField(
document_display_fields = DynamicMultiSelectField(
max_length=128,
verbose_name=_("Dashboard view table display columns"),
verbose_name=_("Document display fields"),
choices=DashboardViewTableColumns.choices,
dyanmic_choices=[DashboardViewDynamicTableColumns.CUSTOM_FIELD],
default=f"{DashboardViewTableColumns.CREATED},{DashboardViewTableColumns.TITLE},{DashboardViewTableColumns.TAGS},{DashboardViewTableColumns.CORRESPONDENT}",

View File

@@ -843,7 +843,7 @@ class DynamicOrderedMultipleChoiceField(fields.MultipleChoiceField):
class SavedViewSerializer(OwnedObjectSerializer):
filter_rules = SavedViewFilterRuleSerializer(many=True)
dashboard_view_table_columns = DynamicOrderedMultipleChoiceField(
document_display_fields = DynamicOrderedMultipleChoiceField(
choices=SavedView.DashboardViewTableColumns.choices,
dyanmic_choices=[("custom_field_%d", CustomField)],
required=False,
@@ -861,7 +861,7 @@ class SavedViewSerializer(OwnedObjectSerializer):
"filter_rules",
"dashboard_view_limit",
"dashboard_view_mode",
"dashboard_view_table_columns",
"document_display_fields",
"owner",
"permissions",
"user_can_change",

View File

@@ -1672,7 +1672,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
"filter_rules": [{"rule_type": 4, "value": "test"}],
"dashboard_view_limit": 20,
"dashboard_view_mode": SavedView.DashboardViewDisplayMode.SMALL_CARDS,
"dashboard_view_table_columns": [
"document_display_fields": [
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
],
@@ -1688,7 +1688,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
SavedView.DashboardViewDisplayMode.SMALL_CARDS,
)
self.assertEqual(
v1.dashboard_view_table_columns,
v1.document_display_fields,
[
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
@@ -1698,7 +1698,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
response = self.client.patch(
f"/api/saved_views/{v1.id}/",
{
"dashboard_view_table_columns": [
"document_display_fields": [
SavedView.DashboardViewTableColumns.TAGS,
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
@@ -1710,7 +1710,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
v1.refresh_from_db()
self.assertEqual(
v1.dashboard_view_table_columns,
v1.document_display_fields,
[
SavedView.DashboardViewTableColumns.TAGS,
SavedView.DashboardViewTableColumns.TITLE,
@@ -1727,7 +1727,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
"filter_rules": [{"rule_type": 4, "value": "test"}],
"dashboard_view_limit": 20,
"dashboard_view_mode": SavedView.DashboardViewDisplayMode.SMALL_CARDS,
"dashboard_view_table_columns": [
"document_display_fields": [
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
],
@@ -1746,7 +1746,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
response = self.client.patch(
f"/api/saved_views/{v1.id}/",
{
"dashboard_view_table_columns": [
"document_display_fields": [
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
SavedView.DashboardViewDynamicTableColumns.CUSTOM_FIELD[0]
@@ -1759,7 +1759,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
v1.refresh_from_db()
self.assertEqual(
v1.dashboard_view_table_columns,
v1.document_display_fields,
[
str(SavedView.DashboardViewTableColumns.TITLE),
str(SavedView.DashboardViewTableColumns.CREATED),
@@ -1772,7 +1772,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
response = self.client.patch(
f"/api/saved_views/{v1.id}/",
{
"dashboard_view_table_columns": [
"document_display_fields": [
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
SavedView.DashboardViewDynamicTableColumns.CUSTOM_FIELD[0] % 99,