lgcosta/paperless-ngx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Dont require empty parameters for bulk edit endpoint

Browse Source
This commit is contained in:
shamoon 2024-03-08 18:49:54 -08:00
parent ce56f79fe1
commit a278024ffd
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/documents/serialisers.py
View File

@ -874,7 +874,7 @@ class BulkEditSerializer(DocumentListSerializer, SetPermissionsMixin):
write_only=True, write_only=True,
) )
parameters = serializers.DictField(allow_empty=True) parameters = serializers.DictField(allow_empty=True, default={}, write_only=True)
def _validate_tag_id_list(self, tags, name="tags"): def _validate_tag_id_list(self, tags, name="tags"):
if not isinstance(tags, list): if not isinstance(tags, list):

8
src/documents/tests/test_api_bulk_edit.py
View File

@ -228,7 +228,7 @@ class TestBulkEditAPI(DirectoriesMixin, APITestCase):
response = self.client.post( response = self.client.post(
"/api/documents/bulk_edit/", "/api/documents/bulk_edit/",
json.dumps( json.dumps(
{"documents": [self.doc1.id], "method": "delete", "parameters": {}}, {"documents": [self.doc1.id], "method": "delete"},
), ),
content_type="application/json", content_type="application/json",
) )
@ -354,7 +354,7 @@ class TestBulkEditAPI(DirectoriesMixin, APITestCase):
self.assertEqual(Document.objects.count(), 5) self.assertEqual(Document.objects.count(), 5)
response = self.client.post( response = self.client.post(
"/api/documents/bulk_edit/", "/api/documents/bulk_edit/",
json.dumps({"documents": [-235], "method": "delete", "parameters": {}}), json.dumps({"documents": [-235], "method": "delete"}),
content_type="application/json", content_type="application/json",
) )
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST) self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
@ -461,7 +461,7 @@ class TestBulkEditAPI(DirectoriesMixin, APITestCase):
response = self.client.post( response = self.client.post(
"/api/documents/bulk_edit/", "/api/documents/bulk_edit/",
json.dumps( json.dumps(
{"documents": [self.doc2.id], "method": "add_tag", "parameters": {}}, {"documents": [self.doc2.id], "method": "add_tag"},
), ),
content_type="application/json", content_type="application/json",
) )
@ -488,7 +488,7 @@ class TestBulkEditAPI(DirectoriesMixin, APITestCase):
response = self.client.post( response = self.client.post(
"/api/documents/bulk_edit/", "/api/documents/bulk_edit/",
json.dumps( json.dumps(
{"documents": [self.doc2.id], "method": "remove_tag", "parameters": {}}, {"documents": [self.doc2.id], "method": "remove_tag"},
), ),
content_type="application/json", content_type="application/json",
) )