Setting proper filename in Content-Disposition

2023-12-16 17:24:41 +01:00 · 2023-12-16 17:24:41 +01:00 · c380b2d902
commit c380b2d902
parent 7ddcaac4cd
1 changed files with 6 additions and 2 deletions
--- a/src/documents/views.py
+++ b/src/documents/views.py
@ -1106,8 +1106,12 @@ class BulkDownloadView(GenericAPIView):
                strategy.add_document(doc)

        with open(temp.name, "rb") as f:
-            response = HttpResponse(f, content_type="application/zip")
-            response["Content-Disposition"] = "attachment"
+            file_extension = "pdf" if single_file else "zip"
+
+            response = HttpResponse(f, content_type=f"application/{file_extension}")
+            response[
+                "Content-Disposition"
+            ] = f'attachment; filename="documents.{file_extension}"'

            return response