- @for (column of savedView.dashboard_view_table_columns; track column; let i = $index) {
+ @for (column of savedView.document_display_fields; track column; let i = $index) {
@if (visibleColumns.includes(column)) {
1 }">
@switch (column) {
@@ -89,7 +89,7 @@
}
}
}
- @if (i === savedView.dashboard_view_table_columns.length - 1) {
+ @if (i === savedView.document_display_fields.length - 1) {
{
+ this.savedView.document_display_fields?.forEach((column) => {
let type: PermissionType = Object.values(PermissionType).find((t) =>
t.includes(column)
)
@@ -254,7 +254,7 @@ export class SavedViewWidgetComponent
const id = column.split('_')[2]
return this.customFields.find((c) => c.id === parseInt(id))?.name
}
- return DASHBOARD_VIEW_TABLE_COLUMNS.find((c) => c.id === column)?.name
+ return document_display_fields.find((c) => c.id === column)?.name
}
public getCustomFieldDataType(column_id: string): string {
@@ -284,7 +284,7 @@ export class SavedViewWidgetComponent
if (this.docLinkDocuments.length) return
let docIds = []
let docLinkColumns = []
- this.savedView.dashboard_view_table_columns
+ this.savedView.document_display_fields
?.filter((column) =>
column.startsWith(DashboardViewTableColumn.CUSTOM_FIELD)
)
diff --git a/src-ui/src/app/data/saved-view.ts b/src-ui/src/app/data/saved-view.ts
index b2f7f6b25..f0564ca59 100644
--- a/src-ui/src/app/data/saved-view.ts
+++ b/src-ui/src/app/data/saved-view.ts
@@ -17,7 +17,7 @@ export enum DashboardViewTableColumn {
CUSTOM_FIELD = 'custom_field_',
}
-export const DASHBOARD_VIEW_TABLE_COLUMNS = [
+export const document_display_fields = [
{
id: DashboardViewTableColumn.TITLE,
name: $localize`Title`,
@@ -65,5 +65,5 @@ export interface SavedView extends ObjectWithPermissions {
dashboard_view_mode?: DashboardViewMode
- dashboard_view_table_columns?: DashboardViewTableColumn[]
+ document_display_fields?: DashboardViewTableColumn[]
}
diff --git a/src/documents/migrations/1047_savedview_dasboard_view_mode_and_more.py b/src/documents/migrations/1047_savedview_dasboard_view_mode_and_more.py
index 0cc64f286..3e19ece0d 100644
--- a/src/documents/migrations/1047_savedview_dasboard_view_mode_and_more.py
+++ b/src/documents/migrations/1047_savedview_dasboard_view_mode_and_more.py
@@ -34,7 +34,7 @@ class Migration(migrations.Migration):
),
migrations.AddField(
model_name="savedview",
- name="dashboard_view_table_columns",
+ name="document_display_fields",
field=multiselectfield.db.fields.MultiSelectField(
choices=[
("title", "Title"),
diff --git a/src/documents/models.py b/src/documents/models.py
index ab508675a..811437c79 100644
--- a/src/documents/models.py
+++ b/src/documents/models.py
@@ -598,9 +598,9 @@ class SavedView(ModelWithOwner):
default=DashboardViewDisplayMode.TABLE,
)
- dashboard_view_table_columns = DynamicMultiSelectField(
+ document_display_fields = DynamicMultiSelectField(
max_length=128,
- verbose_name=_("Dashboard view table display columns"),
+ verbose_name=_("Document display fields"),
choices=DashboardViewTableColumns.choices,
dyanmic_choices=[DashboardViewDynamicTableColumns.CUSTOM_FIELD],
default=f"{DashboardViewTableColumns.CREATED},{DashboardViewTableColumns.TITLE},{DashboardViewTableColumns.TAGS},{DashboardViewTableColumns.CORRESPONDENT}",
diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py
index 4a8852d2e..2382030c8 100644
--- a/src/documents/serialisers.py
+++ b/src/documents/serialisers.py
@@ -838,7 +838,7 @@ class DynamicOrderedMultipleChoiceField(fields.MultipleChoiceField):
class SavedViewSerializer(OwnedObjectSerializer):
filter_rules = SavedViewFilterRuleSerializer(many=True)
- dashboard_view_table_columns = DynamicOrderedMultipleChoiceField(
+ document_display_fields = DynamicOrderedMultipleChoiceField(
choices=SavedView.DashboardViewTableColumns.choices,
dyanmic_choices=[("custom_field_%d", CustomField)],
required=False,
@@ -856,7 +856,7 @@ class SavedViewSerializer(OwnedObjectSerializer):
"filter_rules",
"dashboard_view_limit",
"dashboard_view_mode",
- "dashboard_view_table_columns",
+ "document_display_fields",
"owner",
"permissions",
"user_can_change",
diff --git a/src/documents/tests/test_api_documents.py b/src/documents/tests/test_api_documents.py
index e057cb174..6bdfae0ae 100644
--- a/src/documents/tests/test_api_documents.py
+++ b/src/documents/tests/test_api_documents.py
@@ -1545,7 +1545,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
"filter_rules": [{"rule_type": 4, "value": "test"}],
"dashboard_view_limit": 20,
"dashboard_view_mode": SavedView.DashboardViewDisplayMode.SMALL_CARDS,
- "dashboard_view_table_columns": [
+ "document_display_fields": [
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
],
@@ -1561,7 +1561,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
SavedView.DashboardViewDisplayMode.SMALL_CARDS,
)
self.assertEqual(
- v1.dashboard_view_table_columns,
+ v1.document_display_fields,
[
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
@@ -1571,7 +1571,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
response = self.client.patch(
f"/api/saved_views/{v1.id}/",
{
- "dashboard_view_table_columns": [
+ "document_display_fields": [
SavedView.DashboardViewTableColumns.TAGS,
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
@@ -1583,7 +1583,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
v1.refresh_from_db()
self.assertEqual(
- v1.dashboard_view_table_columns,
+ v1.document_display_fields,
[
SavedView.DashboardViewTableColumns.TAGS,
SavedView.DashboardViewTableColumns.TITLE,
@@ -1600,7 +1600,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
"filter_rules": [{"rule_type": 4, "value": "test"}],
"dashboard_view_limit": 20,
"dashboard_view_mode": SavedView.DashboardViewDisplayMode.SMALL_CARDS,
- "dashboard_view_table_columns": [
+ "document_display_fields": [
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
],
@@ -1619,7 +1619,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
response = self.client.patch(
f"/api/saved_views/{v1.id}/",
{
- "dashboard_view_table_columns": [
+ "document_display_fields": [
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
SavedView.DashboardViewDynamicTableColumns.CUSTOM_FIELD[0]
@@ -1632,7 +1632,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
v1.refresh_from_db()
self.assertEqual(
- v1.dashboard_view_table_columns,
+ v1.document_display_fields,
[
str(SavedView.DashboardViewTableColumns.TITLE),
str(SavedView.DashboardViewTableColumns.CREATED),
@@ -1645,7 +1645,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
response = self.client.patch(
f"/api/saved_views/{v1.id}/",
{
- "dashboard_view_table_columns": [
+ "document_display_fields": [
SavedView.DashboardViewTableColumns.TITLE,
SavedView.DashboardViewTableColumns.CREATED,
SavedView.DashboardViewDynamicTableColumns.CUSTOM_FIELD[0] % 99,
|