diff --git a/src-ui/messages.xlf b/src-ui/messages.xlf index 5f5393e6a..ba49a05d2 100644 --- a/src-ui/messages.xlf +++ b/src-ui/messages.xlf @@ -3460,14 +3460,14 @@ Create new custom field src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.ts - 52 + 53 Edit custom field src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.ts - 56 + 57 diff --git a/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.html b/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.html index 1641ab129..34936b1bb 100644 --- a/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.html +++ b/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.html @@ -16,7 +16,7 @@
@switch (objectForm.get('data_type').value) { @case (CustomFieldDataType.Select) { -
diff --git a/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.spec.ts b/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.spec.ts index 6e56b2929..f1de14f15 100644 --- a/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.spec.ts +++ b/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.spec.ts @@ -86,10 +86,6 @@ describe('CustomFieldEditDialogComponent', () => { component.dialogMode = EditDialogMode.CREATE fixture.detectChanges() component.ngOnInit() - expect( - component.objectForm.get('extra_data').get('select_options').value.length - ).toBe(0) - component.addSelectOption() expect( component.objectForm.get('extra_data').get('select_options').value.length ).toBe(1) @@ -97,9 +93,13 @@ describe('CustomFieldEditDialogComponent', () => { expect( component.objectForm.get('extra_data').get('select_options').value.length ).toBe(2) + component.addSelectOption() + expect( + component.objectForm.get('extra_data').get('select_options').value.length + ).toBe(3) component.removeSelectOption(0) expect( component.objectForm.get('extra_data').get('select_options').value.length - ).toBe(1) + ).toBe(2) }) }) diff --git a/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.ts b/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.ts index 24e7c57ca..f4338db0b 100644 --- a/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.ts +++ b/src-ui/src/app/components/common/edit-dialog/custom-field-edit-dialog/custom-field-edit-dialog.component.ts @@ -42,6 +42,7 @@ export class CustomFieldEditDialogComponent this.objectForm.get('data_type').disable() } if (this.object?.data_type === CustomFieldDataType.Select) { + this.selectOptions.clear() this.object.extra_data.select_options.forEach((option) => this.selectOptions.push(new FormControl(option)) ) @@ -61,7 +62,7 @@ export class CustomFieldEditDialogComponent name: new FormControl(null), data_type: new FormControl(null), extra_data: new FormGroup({ - select_options: new FormArray([]), + select_options: new FormArray([new FormControl(null)]), }), }) }