M2: refcnt_rele polarity, radix SALEN by family, LIST_HEAD dispatch + harness scp-failure hardening (gates 01-03 green)

tests/vm/lib.sh

@@ -8,14 +8,24 @@ pf0() { ssh -o ConnectTimeout=10 "$DEB" "$SSHBASE$PF0_IP \"$*\""; }
 cli() { ssh -o ConnectTimeout=10 "$DEB" "$SSHBASE$CLI_IP \"$*\""; }
 srv() { ssh -o ConnectTimeout=10 "$DEB" "$SSHBASE$SRV_IP \"$*\""; }
 gw2() { ssh -o ConnectTimeout=10 "$DEB" "$SSHBASE$GW2_IP \"$*\""; }
+# Upload a config to pf0.  The scp through the libvirt jump host is
+# occasionally refused ("stdio forwarding failed"); a silent failure used to
+# leave a *stale* config on pf0 (or none at all), which showed up as a
+# bogus gate failure.  Retry and fail loudly instead.
 pfput() {
-	local f="$1"
-	scp -q -o ProxyJump=root@192.168.1.242 -o StrictHostKeyChecking=accept-new \
-		-i "$HOME/.ssh/pflab_ed" "$f" pf0:/tmp/ 2>/dev/null || \
-	ssh "$DEB" "true" # alias must exist; fallback no-op
-	echo "/tmp/$(basename "$f")"
+	local f="$1" i
+	for i in 1 2 3; do
+		if scp -q -o ProxyJump=root@192.168.1.242 -o StrictHostKeyChecking=accept-new \
+			-i "$HOME/.ssh/pflab_ed" "$f" pf0:/tmp/ 2>/dev/null; then
+			echo "/tmp/$(basename "$f")"
+			return 0
+		fi
+		sleep 2
+	done
+	echo "pfput: upload of $f to pf0 failed" >&2
+	return 1
 }
-pfload() { local r; r=$(pfput "$1"); pf0 "/opt/pf/pfctl -f $r" && return 0; return 1; }
+pfload() { local r; r=$(pfput "$1") || return 1; pf0 "/opt/pf/pfctl -f $r" && return 0; return 1; }
 ok()   { echo "OK $*"; }
 bad()  { echo "NOT OK: $*" >&2; FAILED=1; }
 finish(){ [ "${FAILED:-0}" = 1 ] && exit 1; exit 0; }