From 59dc067e7947475eab88fc1a83178f405515d7ca Mon Sep 17 00:00:00 2001 From: Jeff Mahoney Date: Mon, 6 Jun 2016 13:32:40 -0400 Subject: [PATCH] reiserfscore: fix "new_insert_key may be used uninitialized..." new_insert_key only makes any sense when it's associated with a new_insert_ptr, which is initialized to NULL and changed to a buffer_head when we also initialize new_insert_key. We can key off of that to avoid the uninitialized warning. Signed-off-by: Jeff Mahoney --- reiserfscore/ibalance.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/reiserfscore/ibalance.c b/reiserfscore/ibalance.c index 2a24dc9..1977f99 100644 --- a/reiserfscore/ibalance.c +++ b/reiserfscore/ibalance.c @@ -881,8 +881,9 @@ int balance_internal(struct tree_balance *tb, /* tree_balance structure insert_key, insert_ptr); } - memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE); insert_ptr[0] = new_insert_ptr; + if (new_insert_ptr) + memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE); return order; }