lgcosta/reiserfsprogs
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reiserfsprogs: annotate for endian safeness

Browse Source 
By annotating structure members and other on-disk structures as little
endian, we can catch bugs more easily.

The code was already endian safe except for three minor spots:
1) The badblock list code was initializing its key in an endian-unsafe way.
2) Indirect block pointer sequence printing was treating cpu-order values
   as little endian.
3) reiserfsck was trying to do endian switching on the lost+found key,
   but it was before it was even initialized to anything, so we can
   just remove that completely.

These issues were fixed as part of this commit.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
This commit is contained in:
Jeff Mahoney committed 2013-08-26 19:02:20 -04:00
1 parent 767f7b85df
commit 81aeadf510
26 files changed
+241 -220
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

reiserfscore/prints.c
+10 -9
View File
@@ -333,14 +333,14 @@ static void start_new_sequence(__u32 * start, int *len, __u32 new)
static int sequence_finished(__u32 start, int *len, __u32 new)
{
if (le32_to_cpu(start) == INT_MAX)
if (start == INT_MAX)
return 1;
if (start == 0 && new == 0) {
(*len)++;
return 0;
}
if (start != 0 && (le32_to_cpu(start) + *len) == le32_to_cpu(new)) {
if (start != 0 && (start + *len) == new) {
(*len)++;
return 0;
}
@@ -353,20 +353,21 @@ static void print_sequence(FILE * fp, __u32 start, int len)
return;
if (len == 1)
reiserfs_warning(fp, " %u", le32_to_cpu(start));
reiserfs_warning(fp, " %u", start);
else
reiserfs_warning(fp, " %u(%d)", le32_to_cpu(start), len);
reiserfs_warning(fp, " %u(%d)", start, len);
}
void print_indirect_item(FILE * fp, struct buffer_head *bh, int item_num)
{
struct item_head *ih;
unsigned int j;
__u32 *unp, prev = INT_MAX;
__le32 *unp;
__u32 prev = INT_MAX;
int num = 0;
ih = item_head(bh, item_num);
unp = (__u32 *) ih_item_body(bh, ih);
unp = (__le32 *) ih_item_body(bh, ih);
if (get_ih_item_len(ih) % UNFM_P_SIZE)
reiserfs_warning(fp, "print_indirect_item: invalid item len");
@@ -1016,13 +1017,13 @@ void print_objectid_map(FILE * fp, reiserfs_filsys_t *fs)
{
int i;
struct reiserfs_super_block *sb;
__u32 *omap;
__le32 *omap;
sb = fs->fs_ondisk_sb;
if (fs->fs_format == REISERFS_FORMAT_3_6)
omap = (__u32 *) (sb + 1);
omap = (__le32 *) (sb + 1);
else if (fs->fs_format == REISERFS_FORMAT_3_5)
omap = (__u32 *) ((struct reiserfs_super_block_v1 *)sb + 1);
omap = (__le32 *) ((struct reiserfs_super_block_v1 *)sb + 1);
else {
reiserfs_warning(fp,
"print_objectid_map: proper signature is not found\n");