2 Commits

Include renames

Author	SHA1	Message	Date
lgcosta	7b5421ce49	Support clang builds; fix the defects clang and its sanitizers exposed ... Clang (22.1.8 on the host, 14.0.6 in the Debian VM) now builds the tree warning-free with --enable-warnings, in-tree and out-of-tree, with -j, and the full VM battery passes with CC=clang: 12/12. ASan/UBSan builds run the real tool paths (mkfs, check, tune, resize, rollback save/restore/reject) with halt_on_error and report zero errors. Documented in tests/vm/RESULTS.md; the CI gained clang+warnings, out-of-tree and sanitizer jobs. Fixes found by this work: - reiserfscore/Makefile.am: reiserfs_err.c and reiserfs_err.h shared one recipe. With -j, make runs the recipe once per stale target, so two compile_et invocations race: one deletes reiserfs_err.c ("no input files") while another job compiles it. Attached the recipe to reiserfs_err.c only; reiserfs_err.h merely depends on it. Reproduced with clang+ASan, stable across 5 clang / 3 asan / 3 gcc parallel builds. - reiserfscore/Makefile.am: the rule read the source-local reiserfs_err.et, so VPATH builds could not find it. Use $(srcdir)/. make distcheck now passes. - reiserfscore/reiserfslib.c: reiserfs_close() did fsync(fs->fs_dev) after reiserfs_free() released fs -- a 4-byte heap-use-after-free, flagged exactly at reiserfslib.c:406/407 by ASan (found by clang+ASan; gcc never caught it because the freed heap usually still holds the old value). Moved fsync before the free; reiserfs_flush() has already written journal and dirty buffers at that point and free_buffers() never writes, so the ordering preserves durability semantics. - fsck/semantic_check.c, fsck/semantic_rebuild.c: three %K arguments passed &tmp_deh->deh2_dir_id where a struct reiserfs_key * is expected. It printed the right values only because deh2_dir_id sits at offset 4 and the key is read from the pointer as if dir_id sat at offset 0. Build a proper local key with set_key_dirid()/set_key_objectid() (the same idiom debugreiserfs/scan.c already uses). Verified -Waddress-of-packed- member (clang-only) is gone and output is unchanged. - reiserfscore/hashes.c: four unreachable *(int *)0 = 0 stores (guarded by len >= 16/12/8/4 tests that cannot hold after the while (len >= 16) loop, len <= 15). Removed; clang's -Wnull-dereference goes quiet. Behavior verified: keyed_hash/yura_hash/r5_hash outputs for 16 inputs from 0 to 17 bytes are byte-identical before and after. run_in_vm.sh: propagate CC into the guest, force a remount of /mnt/data (the host rewrites the backing file under the guest), exclude generated reiserfs_err.[ch] from the source tar. run_tests.sh: report which compiler the battery actually used.	2026-11-12 08:51:29 -03:00
lgcosta	5a7382185b	Add a libvirt/KVM test environment and fix the gcc-12 warning it found ... The VM harness (tests/vm/) builds and exercises the tools on real Debian and Alpine guests, driving the serial console (no sshd/cloud-init dependency). Results on Debian 12 (glibc 2.36, gcc 12.2): 12/12 checks pass, 0 warnings with -Wall -Wextra, including a real 128M -> 256M resize and the rollback save/restore/reject paths. Results on Alpine 3.20 (musl 1.2.5): the build cannot start. configure stops at "reiserfsprogs requires a method to add printf modifiers" because reiserfscore/prints.c depends on glibc's register_printf_specifier(3) and <printf.h>, which musl does not provide. This is pre-existing and out of scope here; measured at 341 use sites across 20+ files, all routed through reiserfs_warning()/reiserfs_info(). Documented in tests/vm/RESULTS.md. Fix the one real defect the harness surfaced: fsck/semantic_check.c: check_check_regular_file() is called with NULL for new_ih (line 466), so the block that would fill *new_ih is unreachable and check_semantic_pass() never returns RELOCATED through that path. The "case RELOCATED:" arm still reads relocated_ih.ih_key, which gcc 12.2 reports as "may be used uninitialized" (-Wmaybe-uninitialized); gcc 16 does not, because it proves the path dead. Zero-initialise the struct and say why. Verified: 0 warnings on gcc 12.2 after the change, and the Debian battery stays at 12/12.	2026-11-12 00:11:31 -03:00