lgcosta
7b5421ce49
Clang (22.1.8 on the host, 14.0.6 in the Debian VM) now builds the tree
warning-free with --enable-warnings, in-tree and out-of-tree, with -j, and
the full VM battery passes with CC=clang: 12/12. ASan/UBSan builds run the
real tool paths (mkfs, check, tune, resize, rollback save/restore/reject)
with halt_on_error and report zero errors. Documented in tests/vm/RESULTS.md;
the CI gained clang+warnings, out-of-tree and sanitizer jobs.
Fixes found by this work:
- reiserfscore/Makefile.am: reiserfs_err.c and reiserfs_err.h shared one
recipe. With -j, make runs the recipe once per stale target, so two
compile_et invocations race: one deletes reiserfs_err.c ("no input
files") while another job compiles it. Attached the recipe to
reiserfs_err.c only; reiserfs_err.h merely depends on it. Reproduced
with clang+ASan, stable across 5 clang / 3 asan / 3 gcc parallel builds.
- reiserfscore/Makefile.am: the rule read the source-local
reiserfs_err.et, so VPATH builds could not find it. Use $(srcdir)/.
make distcheck now passes.
- reiserfscore/reiserfslib.c: reiserfs_close() did fsync(fs->fs_dev) after
reiserfs_free() released fs -- a 4-byte heap-use-after-free, flagged
exactly at reiserfslib.c:406/407 by ASan (found by clang+ASan; gcc never
caught it because the freed heap usually still holds the old value).
Moved fsync before the free; reiserfs_flush() has already written
journal and dirty buffers at that point and free_buffers() never
writes, so the ordering preserves durability semantics.
- fsck/semantic_check.c, fsck/semantic_rebuild.c: three %K arguments passed
&tmp_deh->deh2_dir_id where a struct reiserfs_key * is expected. It
printed the right values only because deh2_dir_id sits at offset 4 and
the key is read from the pointer as if dir_id sat at offset 0. Build a
proper local key with set_key_dirid()/set_key_objectid() (the same
idiom debugreiserfs/scan.c already uses). Verified -Waddress-of-packed-
member (clang-only) is gone and output is unchanged.
- reiserfscore/hashes.c: four unreachable *(int *)0 = 0 stores (guarded by
len >= 16/12/8/4 tests that cannot hold after the while (len >= 16)
loop, len <= 15). Removed; clang's -Wnull-dereference goes quiet.
Behavior verified: keyed_hash/yura_hash/r5_hash outputs for 16 inputs
from 0 to 17 bytes are byte-identical before and after.
run_in_vm.sh: propagate CC into the guest, force a remount of /mnt/data
(the host rewrites the backing file under the guest), exclude generated
reiserfs_err.[ch] from the source tar. run_tests.sh: report which compiler
the battery actually used.
Ambiente de testes em VM
Este documento descreve o ambiente de validação do reiserfsprogs em máquinas virtuais (libvirt/KVM), usado para exercitar o build e as ferramentas em distribuições diferentes da máquina de desenvolvimento.
O ambiente é efêmero: as VMs ficam em /var/tmp/vmtest e não fazem parte
do repositório. Os scripts que o reproduzem estão em tests/vm/.
Requisitos do host
| Componente | Verificação |
|---|---|
| KVM | ls -l /dev/kvm |
| libvirt (user session) | virsh -c qemu:///session list --all |
virt-install, qemu-img |
which virt-install qemu-img |
guestfs-tools (offline) |
which virt-customize |
mkisofs ou xorriso |
which mkisofs xorriso |
No Fedora: sudo dnf install libvirt-daemon-kvm qemu-kvm virt-install guestfs-tools genisoimage.
O ambiente usa qemu:///session (sem root). Não requer a rede default
do libvirt: a conectividade vem do backend passt em modo user.
Topologia
graph LR
H[host] -->|qemu:///session| D[rfs-debian<br/>Debian 12 · gcc + clang]
H -->|qemu:///session| A[rfs-alpine<br/>Alpine 3.20 · gcc/musl]
D -->|passt :2222| S[ssh opcional]
A -->|passt| S
H -->|attach-disk| V[vdb: fontes + run_tests.sh]
Cada VM recebe:
- imagem cloud (qcow2) redimensionada para 8 GiB;
- um disco de dados
vdb(ext4) comrfs-src.tar.gzerun_tests.sh; - acesso por console serial (pty do libvirt), que é o canal de automação usado — independente de rede.
Por que console serial e não SSH
Nas imagens cloud o sshd demora a subir e o cloud-init nem sempre aplica
a senha (o datasource NoCloud exige rótulo cidata e o CD precisa estar no
Barramento certo). O console serial está disponível assim que o getty sobe e
é suficiente para: autenticar, copiar arquivos (já estão no vdb) e rodar
qualquer comando. Por isso o tests/vm/guestcmd.py dirige o pty.
Ciclo de uso
cd tests/vm
# 1. preparar imagens e VMs (uma vez)
./setup_env.sh
# 2. rodar a bateria em uma VM
./run_in_vm.sh rfs-debian # gcc do guest
CC=clang ./run_in_vm.sh rfs-debian # clang do guest
./run_in_vm.sh rfs-alpine # esperado FALHAR no configure (musl)
# 3. destruir tudo
./teardown_env.sh
No Debian, instale o clang no guest uma vez (a rede user-mode do passt
precisa de resolver manual antes do apt):
python3 guestcmd.py rfs-debian 'ip addr add 192.168.1.5/24 dev enp1s0;
ip link set enp1s0 up; ip route add default via 192.168.1.1;
echo nameserver 8.8.8.8 > /etc/resolv.conf;
apt-get update -qq && DEBIAN_FRONTEND=noninteractive \
apt-get install -y -qq clang'
Compiladores suportados
O projeto compila sem warnings com -Wall -Wextra em gcc (>= 12) e
clang (>= 14; validado em 14.0.6 e 22.1.8). Os mesmos builds são exercitados
sob AddressSanitizer + UndefinedBehaviorSanitizer (CC=clang CFLAGS="-g -O1 -fsanitize=address,undefined ...") tanto no host (CI) quanto
manualmente; resultados em RESULTS.md.
O que a bateria cobre (tests/vm/run_tests.sh)
Executado dentro do guest, sobre o código extraído do vdb:
autogen.sh && configure --enable-warnings && make -j— build limpo;- contagem de warnings (esperado: 0);
mkreiserfsem imagem de 64 MiB;reiserfsck --check(esperado: No corruptions found);debugreiserfs -S(superblock consistente);reiserfstune -l(troca de label);resize_reiserfs128 MiB → 256 MiB;reiserfsckpós-resize;- rollback:
-Rgrava,--rollback-fsck-changesrestaura, arquivo inválido é rejeitado.
Resultados obtidos
Ver tests/vm/RESULTS.md.