Catch exception during trash-move

2022-02-20 14:04:43 +01:00 · 2022-02-20 14:04:43 +01:00 · a7e1c1c4d0
commit a7e1c1c4d0
parent 335b8c63e0
1 changed files with 8 additions and 1 deletions
--- a/src/documents/signals/handlers.py
+++ b/src/documents/signals/handlers.py
@ -247,7 +247,14 @@ def cleanup_document_deletion(sender, instance, using, **kwargs):

            logger.debug(
                f"Moving {instance.source_path} to trash at {new_file_path}")
-            os.rename(instance.source_path, new_file_path)
+            try:
+                os.rename(instance.source_path, new_file_path)
+            except OSError as e:
+                logger.error(
+                    f"Failed to move {instance.source_path} to trash at "
+                    f"{new_file_path}: {e}. Skipping cleanup!"
+                )
+                return

        for filename in (instance.source_path,
                         instance.archive_path,